Skip to content

[JavaJaxRs] generate getValue() for enums with the correct type#21183

Merged
wing328 merged 36 commits intoOpenAPITools:masterfrom
eric-rolli:master
May 9, 2025
Merged

[JavaJaxRs] generate getValue() for enums with the correct type#21183
wing328 merged 36 commits intoOpenAPITools:masterfrom
eric-rolli:master

Conversation

@eric-rolli
Copy link
Copy Markdown
Contributor

@eric-rolli eric-rolli commented Apr 29, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

JavaJaxRs enums are missing getValue() method returning the correct data type.
@eric-rolli
Copy link
Copy Markdown
Contributor Author

The model classes with jaxrs-jersey the enums are generated but without getValue() method and with the JsonValue annotation for the toString() method. This produces invalid json when the enum has another type as string (e.g. type integer). The solution is to add the getValue() method with JsonValue annotation and the correct return type.
@hiveship @wing328

@eric-rolli
Copy link
Copy Markdown
Contributor Author

@wing328 who can review and approve this correction?

@wing328
Copy link
Copy Markdown
Member

wing328 commented May 9, 2025

@eric-rolli thanks for the pr

let's give it a try

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328 wing328 merged commit bb811db into OpenAPITools:master May 9, 2025
37 checks passed
@eric-rolli
Copy link
Copy Markdown
Contributor Author

Thanks

@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants